atfatmc/AdamuSw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Keep a money basis for party members at max level without master quest

Browse Source 
AwardExperienceAsync returned 0 for a character at the maximum level which has
not completed the master quest: it gains neither normal nor master experience.
Since the money of a kill is now derived from those returned values, such a
member got no zen at all in a party, while the same character still earns zen
when killing solo - AddExpAfterKillAsync returns the calculated amount there,
regardless of whether it could be applied.

The normal experience is now always calculated and returned, and only awarded
when the character can still gain it.

(cherry picked from commit 7cdb34b7c58f5924427b97ea17f26c3fe0f37719)
This commit is contained in:
nolt
2026-07-24 14:48:40 +02:00
committed by Acentech Dev
parent 6307ecfc24
commit d7c589fc45
2 changed files with 43 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
tests/MUnique.OpenMU.Tests/ExperienceRateSplitTest.cs
View File

@@ -113,6 +113,39 @@ public class ExperienceRateSplitTest
Assert.That(masterGained, Is.GreaterThan(normalGained * 3));
}
/// <summary>
/// Verifies that a party member at the maximum level without the master quest still gets a
/// money basis. It gains no experience, but the money drop is derived from that value, and a
/// solo kill returns it too - so returning zero would leave it without any zen in a party.
/// </summary>
[Test]
public async ValueTask MaxLevelMemberWithoutMasterQuestStillHasMoneyBasisAsync()
{
var context = this.CreateGameServerContext(
normalExperienceRate: 1.0f,
globalMasterExperienceRate: 1.0f,
maximumLevel: 3,
maximumMasterLevel: 200);
var maxedPlayer = await this.CreatePlayerAsync(context, level: 3, totalLevel: 3, isMasterClass: false).ConfigureAwait(false);
var levelingPlayer = await this.CreatePlayerAsync(context, level: 2, totalLevel: 2, isMasterClass: false).ConfigureAwait(false);
var party = new Party(new PartyManager(5, new NullLogger<Party>()), 5, new NullLogger<Party>());
await party.AddAsync(maxedPlayer).ConfigureAwait(false);
await party.AddAsync(levelingPlayer).ConfigureAwait(false);
await maxedPlayer.AddObserverAsync(levelingPlayer).ConfigureAwait(false);
var killedObject = CreateKilledObject(level: 5);
var shares = await party.DistributeExperienceAfterKillAsync(killedObject.Object, maxedPlayer).ConfigureAwait(false);
var maxedShare = shares.First(s => s.Player == maxedPlayer);
Assert.That(maxedShare.Experience, Is.GreaterThan(0));
// It still must not actually gain any experience.
Assert.That(maxedPlayer.SelectedCharacter!.Experience, Is.EqualTo(0));
Assert.That(maxedPlayer.SelectedCharacter.MasterExperience, Is.EqualTo(0));
}
/// <summary>
/// Verifies that concurrent normal experience gains cannot exceed the maximum level.
/// </summary>